Skip to content

remove beginning/end offsets request version limit #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2017
Merged

remove beginning/end offsets request version limit #1200

merged 1 commit into from
Sep 10, 2017

Conversation

Jiayi-Liao
Copy link

  • Remove beginning_offset and end_offset version limit because the kafka service of lower versions can get accurate offsets in these two functions.
    Our discussion is in #1199

@Jiayi-Liao Jiayi-Liao mentioned this pull request Sep 4, 2017
Closed
@tvoinarovskyi
Copy link
Collaborator

Yea, this is good!

@tvoinarovskyi tvoinarovskyi merged commit 3701690 into dpkp:master Sep 10, 2017
@Jiayi-Liao Jiayi-Liao deleted the offset branch September 11, 2017 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiayi-Liao @tvoinarovskyi