Avoid multiple connection attempts when refreshing metadata #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkp
force-pushed
the
metadata_wait_for_connect
branch
from
af244a4 to
d39fdd7
Compare
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 25, 2017
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following upstream KAFKA-4024, this revision prevents connecting to multiple nodes simultaneously during metadata refresh when the least loaded node(s) is/are not currently connected.
KAFKA-4024 also includes a fix to avoid potentially waiting for the retry_backoff_ms period before refreshing topic metadata after the topic subscription changes. That change is not included here.