Skip to content

fix: Issue with searchPredicate function second argument(searchTerm) #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Issue with searchPredicate function second argument(searchTerm) #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3f7dcb
Update index.js
manish-dalal Nov 25, 2020
56f387f
Fix test
manish-dalal Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tree-manager/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class TreeManager {
}

filterTree(searchTerm, keepTreeOnSearch, keepChildrenOnSearch) {
const matches = this.getMatches(searchTerm.toLowerCase())
const matches = this.getMatches(searchTerm)

const matchTree = new Map()

Expand Down Expand Up @@ -289,7 +289,7 @@ class TreeManager {
}

_getAddOnMatch(matches, searchTerm) {
let isMatch = (node, term) => node.label.toLowerCase().indexOf(term) >= 0
let isMatch = (node, term) => node.label.toLowerCase().indexOf(term.toLowerCase()) >= 0
if (typeof this.searchPredicate === 'function') {
isMatch = this.searchPredicate
}
Expand Down
3 changes: 2 additions & 1 deletion src/tree-manager/tests/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,8 @@ test('should get matching nodes when using custom search predicate', t => {
},
],
}
const searchPredicate = (node, term) => node.customField && node.customField.toLowerCase().indexOf(term) >= 0
const searchPredicate = (node, term) =>
node.customField && node.customField.toLowerCase().indexOf(term.toLowerCase()) >= 0
const manager = new TreeManager({ data: tree, searchPredicate })
const { allNodesHidden, tree: matchTree } = manager.filterTree('tEaPoT')
t.false(allNodesHidden)
Expand Down