Skip to content

Conversation

mrchief
Copy link
Collaborator

@mrchief mrchief commented Jan 10, 2020

What does it do?

Gets rid of classnames dependency. This package was not being used for its main features anyway (just for emitting classnames conditionally).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 65c9727 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1311

  • 5 of 5 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 95.184%

Totals Coverage Status
Change from base Build 1294: -0.1%
Covered Lines: 581
Relevant Lines: 594

💛 - Coveralls

@mrchief mrchief merged commit 0b9d922 into develop Jan 10, 2020
@mrchief mrchief deleted the feat/reduce_deps branch January 10, 2020 02:32
mrchief added a commit that referenced this pull request Jan 11, 2020
Gets rid of classnames dependency. This package was not being used for its main features anyway (just for emitting classnames conditionally).
m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Sep 20, 2020
Gets rid of classnames dependency. This package was not being used for its main features anyway (just for emitting classnames conditionally).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants