fix: Adjust aria labels to reference selections and read Remove #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellinge
changed the title
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 1279
💛 - Coveralls |
mrchief
reviewed
Jul 5, 2019
mrchief
reviewed
Jul 5, 2019
mrchief
reviewed
Jul 5, 2019
|
Code Climate has analyzed commit 8eefed7 and detected 0 issues on this pull request. View more on Code Climate. |
mrchief
reviewed
Jul 10, 2019
mrchief
reviewed
Jul 10, 2019
mrchief
reviewed
Jul 10, 2019
mrchief
approved these changes
Jul 23, 2019
mrchief
pushed a commit
that referenced
this pull request
Jul 23, 2019
and ensure "Remove" label is read by Screen readers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
We had some, hard to interpret, feedback about aria/labels from a third party checking accessibility.
So, I installed NVDA to check more exactly how a screen reader interprets all the aria-attributes the component outputs. Anyway, I noticed that the aria-label="Remove" was not spoken. I tried with Firefox and Chrome (and ChromeVox with Chrome).
Also, the selections are not read when focusing on the whole dropdown/trigger, so added them as additional labelled by references. It then reads the label + the tags selected when focusing on the dropdown. It’s how the example on W3 works as well. It reads ~ “Choose an element Neptunium menu button sub menu”.
Type of change