feat: Add support for custom search filtering on nodes (#270) ✨ #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellinge
changed the title
Pull Request Test Coverage Report for Build 1249
💛 - Coveralls |
mrchief
reviewed
Jun 27, 2019
ellinge
changed the title
mrchief
reviewed
Jun 28, 2019
mrchief
reviewed
Jun 28, 2019
mrchief
reviewed
Jun 28, 2019
mrchief
changed the title
|
Code Climate has analyzed commit 1a52123 and detected 0 issues on this pull request. View more on Code Climate. |
mrchief
approved these changes
Jun 29, 2019
mrchief
changed the title
mrchief
reviewed
Jun 29, 2019
| - [always](#always) | ||
| - [form states (disabled|readOnly)](#formstates) | ||
| - [id](#id) | ||
| - [searchPredicate](#searchPredicate) |
There was a problem hiding this comment.
This needs to be all lowercase like (#searchpredicate). GH doesn't link otherwise. Gets me everytime. :)
But don't submit another PR. I'll be fixing this in a doc update. Experimenting with a new readme layout that doesn't need so much scrolling.
Something like
mrchief
pushed a commit
that referenced
this pull request
Jul 23, 2019
New prop: `searchPredicate` - Adds support to filter nodes using custom search logic. For details, checkout README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds an additional property, searchPredicate, which is used when filtering/searching for nodes.
Can be used to have acronyms and other metadata, which should cause a match/hit, or to implement a fuzzy search.
Fixes #269
Type of change