Skip to content

Conversation

mrchief
Copy link
Collaborator

@mrchief mrchief commented May 4, 2019

What does it do?

Removes babel-runtime from the distribution bundle, reducing the size of the component. babel-runtime is only needed for tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 7d43b97 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

coveralls commented May 4, 2019

Pull Request Test Coverage Report for Build 1127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.486%

Totals Coverage Status
Change from base Build 1123: 0.0%
Covered Lines: 564
Relevant Lines: 579

💛 - Coveralls

@mrchief mrchief changed the title fix: Remove babel-runtime from distribution bundle fix: Remove babel-runtime from distribution bundle (#248) 🔥 May 6, 2019
@mrchief mrchief merged commit 071e7f5 into develop May 6, 2019
@mrchief mrchief deleted the fix/remove-babel-runtime branch May 6, 2019 01:35
mrchief added a commit that referenced this pull request May 6, 2019
* fix: Remove babel-runtime from distribution bundle

babel-runtime is only needed for tests

* chore: Do not auto open stats everytime

(cherry picked from commit 071e7f5)
@ellinge
Copy link
Collaborator

ellinge commented May 6, 2019

https://bundlephobia.com/[email protected] postreview, looks good 👍

@mrchief
Copy link
Collaborator Author

mrchief commented May 6, 2019

We're growing but that's because we're now doing more.

I'd like to bring to single digit (gzip+min) :)

@mrchief
Copy link
Collaborator Author

mrchief commented Jun 10, 2019

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants