feat: Ability to keep the dropdown open always (#241) ✨

[moonjy1993]

What does it do?

This adds a new prop: showDropdownAlways, and this disables the toggling of showDropdown when the user clicks search box.

Fixes # (issue)

This closes issue #239.

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• Updated documentation (if applicable)
• Added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• My changes generate no new warnings
• Added myself to contributors table
• I have updated docs/bundle.js file (ran yarn build:docs and checked in the new bundle.js file)

[coveralls]

Pull Request Test Coverage Report for Build 1089

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 95.775%

---

Totals
Change from base Build 1080:	0.2%
Covered Lines:	357
Relevant Lines:	364

---

💛 - Coveralls

[mrchief]

@moonjy1993 Thanks for submitting this. There are a few things we need to do before this PR can be merged:

• Add unit tests for newly added functionality
• Update Readme for the new prop
• Update the PR description according to the checklist.

[ellinge]

Probably should think about bundling this as well.
Change showDropdown to ’onfocus’ (default) | ’initial’ | ’always’ or something similar instead?

[moonjy1993]

@ellinge
but what happens if the user who's already using showDropdown to true in their code?

[mrchief]

Probably should think about bundling this as well.
Change showDropdown to ’onfocus’ (default) | ’initial’ | ’always’ or something similar instead?

Yes, but we can make that part of #242

but what happens if the user who's already using showDropdown to true in their code?

They would need a code update when they migrate to the new version, which is why it's a separate release.

[moonjy1993]

@mrchief okay. so I have updated the index.test.js and readMe files. will include showDropdownAlways for now, since you said the prop bundling will happen in other PR.

[ellinge]

The typescript typings (.d.ts) needs an update as well. It’s a very newly added addition so there’s no checklist or similar which ensures this yet.

[moonjy1993]

@ellinge okay. just modified d.ts file.

[mrchief]

The typescript typings (.d.ts) needs an update as well. It’s a very newly added addition so there’s no checklist or similar which ensures this yet.

Gotta remember this myself! :)

[qlty-cloud-legacy]

Code Climate has analyzed commit 179e1bc and detected 0 issues on this pull request.

View more on Code Climate.

[mrchief]

Thanks for sending this!

[mrchief]

@allcontributors[bot] Let's add @moonjy1993 for code, bug

[allcontributors]

@mrchief

I've put up a pull request to add @moonjy1993! 🎉

[mrchief]

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀