Skip to content

Conversation

MomchilGorchev
Copy link

This is a feature proposal of allowing functions to be passed to override the node and toggle icon renders. This provides easy way of customisation. Please review, test and let me know if im not missing something, will update the docs if it gets green light 👍

@MomchilGorchev MomchilGorchev changed the title Feature: Allow passing function to override node render feat: Allow passing function to override node render Aug 24, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 89.574% when pulling bc57334 on MomchilGorchev:feature/enable-node-override into 05005c1 on dowjones:develop.

@mrchief
Copy link
Collaborator

mrchief commented Sep 2, 2018

@MomchilGorchev Thanks for this PR.

This is an advanced feature and we'd need a few things if we want to support this properly:

  • Documentation - What these do, how to write one of these, what are the rules, when to use one and so on.
  • Live Examples
  • Tests - Node and Icon renderer are integral to proper working of the component, so it needs to have proper tests.

Let me know if you have any questions.

@MomchilGorchev
Copy link
Author

Hey, Im sorry for the late reply, will create docs, live examples and test and will ping you back for review!
Thanks!

@stale
Copy link

stale bot commented Sep 25, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants