Disable Automatic Scrolling on Selection

[aigyptios]

I apologize in advance if this question has already been asked/request has already been made--I searched the issue tracker for anything like this and I was not able to find anything specifically targeting this issue, though it's related to #259 and #257

Is your feature request related to a problem? Please describe.
I'm working on a project and we'd like to be able to disable the automatic centering of the most recently selected node. Right now, whenever we select a node, the scrollTop is set due to:

react-dropdown-tree-select/src/tree/index.js

Line 59 in 060a05a

scrollableTarget.scrollTop = activeLi.offsetTop - (scrollableTarget.clientHeight - activeLi.clientHeight) / 2

and this makes it jump a bit, which we want to avoid.

Describe the solution you'd like
I'm not sure whether it's already possible, but is there a way to disable this? Perhaps by exposing a prop, if it doesn't clutter the API?

Thank you!

[mrchief]

Are you re-rendering on every selection?

[aigyptios]

Nope; we're not re-rendering the <DropdownTreeSelect> component.

[mrchief]

The line you referenced is from CWRP which means it's a re-render, so I was curious. I've not seen this jump behavior so was trying to see how to repro this. Will it be possible for you to create a sandbox or a gif with the issue?

[aigyptios]

I'm unable to create a sandbox or gif, but we noticed that it's happening here too: https://dowjones.github.io/react-dropdown-tree-select/#/story/large-tree

To recreate: if you expand the node labeled "Zitius", and then select the checkbox for "rektangle28-1", the scroll will change to center the selected node.

(We're also using a large number of nodes, though not as many as in the example there.)

[mrchief]

Yeah I see it. It's just there to optimistically load more items without having the user to scroll more. Also helps center the item to make it center of the attention sort of. But I also can see your point. I think it should be OK to not let it move. The tweaks would be around the lines you mentioned.

I'm swamped at the moment so it could take a while to get the fix in. Or feel free to send a PR.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[aarce-uncharted]

Hi, we have similar issues and since it had been open for awhile, I put up a pr to address the issue.

[github-actions]

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀