Remove dead code in FontSourceCollection/FontSource (+ hollow CAS remnants) #9838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
harshit7962
added
Status:InProgress
Status:Proposed
Included in test pass
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
himgoyalmicro
approved these changes
Dec 10, 2024
Contributor
|
Thank you @h3xds1nz for your contribution 😄 |
Member
Author
|
@himgoyalmicro Thank you for including it :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
skipDemandfromFontSourceas it is not used for anything anymore, it was used inNetFxfor figuring out whether to demand permissions.Also removes
isWindowsFontsfromFontSourceCollection, because this is already a dead code in latestNetFxas the internal constructor fromFamilyCollectionthat allowedtruehas been removed at the same time it stopped deriving fromIFontCacheElementand it has been replaced byFamilyCollection.FromWindowsFontswhich uses DirectWrite factory, so it never reachesFontSourceCollectionon this code path. It is also way faster if you would run it.Customer Impact
Smaller code size of
PresentationCore, cleaner code size for developers, faster JITTing, decreased allocs.Regression
No.
Testing
Local build, app run, work with custom font sources.
Risk
Low, as it is a dead code. I do not believe anything relies on the original shape of the ctors either.
Microsoft Reviewers: Open in CodeFlow