Remove obsolete TARGETTING35SP1 preprocessor directive and dead code within #9744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
harshit7962
added
Included in test pass
Status:Committed
Status:Proposed
and removed
Status:Committed
labels
dipeshmsft
approved these changes
Oct 1, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes obsolete
TARGETTING35SP1preprocessor directive used inSystem.Xamland removes the essentially dead code within those blocks (implementation ofLazy<T>came withnet4and more up-to-dateWeakDictionaryis inMS.Internal).Customer Impact
None, just cleaner codebase.
Regression
No.
Testing
Local build.
Risk
None, just removes dead code.
Microsoft Reviewers: Open in CodeFlow