Remove SafeSecurityHelper.GetCultureInfoByIetfLanguageTag proxy for code quality #9733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
harshit7962
added
Status:InProgress
Status:Proposed
Included in test pass
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
h3xds1nz
force-pushed
the
securityhelper-cultureproxy
branch
from
99a5088 to
af24279
Compare
Member
Author
|
Fixed merge conflicts after #9855 for this really big PR. |
himgoyalmicro
approved these changes
Dec 18, 2024
Contributor
|
Thank you @h3xds1nz for the contribution 😄 |
Member
Author
|
@himgoyalmicro Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
SafeSecurityHelper.GetCultureInfoByIetfLanguageTagmethod and replaces it directly withCultureInfo.GetCultureInfoByIetfLanguageTag.One of the few leftover remnants from CAS times, there is no reason for this proxy method anymore.
Customer Impact
Few bytes less in size of PresentationCore.
Regression
No.
Testing
Local build.
Risk
None.
Microsoft Reviewers: Open in CodeFlow