Enable APICompat in WPF Builds #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mblies are being built.
… exist. Starting implementation of repo-specific ApiCompat so that things just work when code is internal or public.
…sembly names are shared between lib/ref/cycle-breakers.
…never shipped as ref assemblies in .NET 4.8, so we don't need to verify compat for them.
…lished in .NET Framework.
… in the port. Some errors may still arise from the build here as there are open issues still.
ghost
added
the
ghost
requested review from
rladuca
added
the
Enhancement Requested
stevenbrix
reviewed
Jun 6, 2019
Member
Author
|
Having some issues getting ref compat to run, working them out now. |
…m our compiler generated ref assemblies to .NET 4.8. This also will enable hand-crafted ref assembly compat vs the associate lib assembly and cycle-break api compat.
Member
Author
|
We can now run API compat both against .NET 4.8 and lib vs hand-crafted ref. Still don't have cycle-breakers working, but that's not much different from hand-crafted ref. |
rladuca
commented
Jun 8, 2019
rladuca
changed the title
stevenbrix
reviewed
Jun 10, 2019
stevenbrix
reviewed
Jun 10, 2019
src/Microsoft.DotNet.Wpf/ApiCompat/Baselines/PresentationBuildTasks-Net48.baseline.txt
Show resolved
Hide resolved
stevenbrix
reviewed
Jun 10, 2019
stevenbrix
suggested changes
Jun 10, 2019
Contributor
stevenbrix
left a comment
stevenbrix
left a comment
There was a problem hiding this comment.
See comments about documentation and improving the error message when api compat fails
Member
Author
I resolved your comments against the documentation. Let me know if you have any specific comments relating to that. |
vatsan-madhavan
approved these changes
Jun 11, 2019
stevenbrix
approved these changes
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #724
See: https://github.com/rladuca/ApiCompatNotes/blob/master/ApiCompat%20Notes.txt
This sets up and enables API Compat against .NET 4.8 reference assemblies and also ensures compat between hand-crafted ref assemblies and their lib counterparts.