Skip to content

Support Microsoft.NetCore.App.Wpf and Microsoft.NetCore.App.WinForms profiles in Microsoft.NET.Sdk.WidnowsDesktop #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

Support Microsoft.NetCore.App.Wpf and Microsoft.NetCore.App.WinForms profiles in Microsoft.NET.Sdk.WidnowsDesktop #868

merged 1 commit into from
Jun 5, 2019

Conversation

@vatsan-madhavan
Copy link
Member

@vatsan-madhavan vatsan-madhavan commented Jun 4, 2019 •
edited
Loading

Fixes #866

Related: WindowsDesktop reference assembly split

UseWPF UseWindowsForms FrameworkReference
False False Error (Will be addressed in #867)
True False Microsoft.WindowsDesktop.App.WPF
False True Microsoft.WindowsDesktop.App.WindowsForms
True True Microsoft.WindowsDesktop.App

@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 4, 2019
@vatsan-madhavan vatsan-madhavan self-assigned this Jun 4, 2019
@vatsan-madhavan
Copy link
Member Author

vatsan-madhavan commented Jun 4, 2019 •
edited
Loading

/cc @dsplaisted, @livarcocc

@vatsan-madhavan vatsan-madhavan added this to the Preview milestone Jun 4, 2019
@nguerrera
Copy link

nguerrera commented Jun 4, 2019

Looks good. Since this is the final piece to get this working end to end, have we validated that things are working?

@vatsan-madhavan
Copy link
Member Author

vatsan-madhavan commented Jun 4, 2019 •
edited
Loading

Looks good. Since this is the final piece to get this working end to end, have we validated that things are working?

Yeah, I built a local SDK, copied it over an installed version of the SDK, and did a few builds - WPF, WinForms, WPF and WinForms, not-WPF and not-WinForms. Everything seemed to work as expected.

For e.g., when UseWpf=true, I could see Microsoft.WindowsDesktop.App.Wpf in RestoreGraphEntry, etc.

@dsplaisted
Copy link
Member

dsplaisted commented Jun 4, 2019

Note that the FrameworkReference names in the table in the PR description are out of date. We decided to use . instead of |.

@vatsan-madhavan
Copy link
Member Author

vatsan-madhavan commented Jun 4, 2019

Note that the FrameworkReference names in the table in the PR description are out of date. We decided to use . instead of |.

Fixed the table. The impl. already had this right.

@vatsan-madhavan vatsan-madhavan merged commit d1280eb into master Jun 5, 2019
@vatsan-madhavan vatsan-madhavan deleted the dev/vatsan/frmrkref-profiles branch June 5, 2019 00:41
This was referenced Jun 14, 2019
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rladuca rladuca Awaiting requested review from rladuca

@dsplaisted dsplaisted Awaiting requested review from dsplaisted

1 more reviewer

@nguerrera nguerrera nguerrera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vatsan-madhavan vatsan-madhavan

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

Preview

Development

Successfully merging this pull request may close these issues.

Support Microsoft.NetCore.App.Wpf and Microsoft.NetCore.App.WinForms profiles in Microsoft.NET.Sdk.WidnowsDesktop

4 participants

@vatsan-madhavan @nguerrera @dsplaisted