Update TFM from .NET 8 to .NET 9 #8301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
pchaurasia14
approved these changes
Oct 13, 2023
dreddy-work
reviewed
Oct 13, 2023
| <WindowsDesktopARM64Support>true</WindowsDesktopARM64Support> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <TargetFrameworkVersion>8.0</TargetFrameworkVersion> | ||
| <TargetFramework>net9.0</TargetFramework> |
Member
There was a problem hiding this comment.
@singhashish-wpf, why can't you use NetCurrent and NetPrevious variables defined by arcade?
Member
There was a problem hiding this comment.
Those properties aren't really used by many repositories yet. Consider filing an issue to track the work to switch to these properties.
ViktorHofer
reviewed
Oct 13, 2023
| And $(TargetFramework) == 'net8.0' | ||
| And Exists('$(PkgMicrosoft_Private_Winforms)\ref\net7.0\%(MicrosoftPrivateWinFormsReference.Identity).dll')"> | ||
| And $(TargetFramework) == 'net9.0' | ||
| And Exists('$(PkgMicrosoft_Private_Winforms)\ref\net8.0\%(MicrosoftPrivateWinFormsReference.Identity).dll')"> |
Member
There was a problem hiding this comment.
Why is this the TFM folder in the Microsoft.Private.Winforms package net8.0 instead of net9.0?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TFM from .NET 8 to .NET 9
Microsoft Reviewers: Open in CodeFlow