Modified templates to use Implicit Usings #6973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
dipeshmsft
requested review from
RussKie,
pchaurasia14 and
singhashish-wpf
and removed request for
SamBent and
singhashish-wpf
RussKie
reviewed
Aug 30, 2022
Contributor
RussKie
left a comment
RussKie
left a comment
There was a problem hiding this comment.
It's a good start, though we can push it a little further.
...aging/Microsoft.Dotnet.Wpf.ProjectTemplates/content/WpfApplication-CSharp/net6.0/App.xaml.cs
Show resolved
Hide resolved
...aging/Microsoft.Dotnet.Wpf.ProjectTemplates/content/WpfApplication-CSharp/net6.0/App.xaml.cs
Show resolved
Hide resolved
Contributor
|
@vlada-shubina FYI |
...oft.Dotnet.Wpf.ProjectTemplates/content/WpfApplication-CSharp/.template.config/template.json
Outdated
Show resolved
Hide resolved
Member
vlada-shubina
left a comment
vlada-shubina
left a comment
There was a problem hiding this comment.
I also left some comments inline.
Please consider localizing the templates. Most of the templates in .NET SDK are now localized
...oft.Dotnet.Wpf.ProjectTemplates/content/WpfApplication-CSharp/.template.config/template.json
Show resolved
Hide resolved
...oft.Dotnet.Wpf.ProjectTemplates/content/WpfApplication-CSharp/.template.config/template.json
Outdated
Show resolved
Hide resolved
Member
|
Also, are these changes planned for .NET 7 or .NET 8? The changes for .NET 7 templates are frozen by Tactics. |
lindexi
reviewed
Aug 31, 2022
Member
|
Should rename the |
Contributor
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
RussKie
reviewed
Sep 14, 2022
...icrosoft.Dotnet.Wpf.ProjectTemplates/content/WpfApplication-CSharp/net6.0/MainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Sep 14, 2022
...ft.Dotnet.Wpf.ProjectTemplates/content/WpfCustomControlLibrary-CSharp/net5.0/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
dipeshmsft
force-pushed
the
implicit-using-templates
branch
from
8f6f90b to
7624973
Compare
singhashish-wpf
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5790
Main PR
Description
Modified templates to support Implicit Usings for .NET 6 and later versions.
Customer Impact
Developers creating new WPF applications will get Implicit Usings C# feature enabled by default.
Regression
No
Testing
Testing in progress. Installed and built the modified templates for different framework versions.
Risk
None
Microsoft Reviewers: Open in CodeFlow