Reuse bool box objects in UncommonField<bool>.SetValue #6528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some scenarios, these UncommonField<bool>s end up being set very frequently, and each time the value being passed in gets boxed. We can avoid that by caching and reusing a box for each of the only two possible values (though it looks like the default value is almost always false and so it mainly only boxes true).
ghost
requested review from
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/UncommonField.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
May 5, 2022
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/UncommonField.cs
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
dipeshmsft
approved these changes
May 20, 2022
This was referenced Jun 9, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some scenarios, these UncommonFields end up being set very frequently, and each time the value being passed in gets boxed. We can avoid that by caching and reusing a box for each of the only two possible values (though it looks like the default value is almost always false and so it mainly only boxes true).
Customer Impact
Unnecessary allocation
Regression
No
Testing
CI
Risk
Minimal.
Microsoft Reviewers: Open in CodeFlow