Set TargetingPackVersion intentionally #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excluding Test projects from RuntimeFrameworkVersion.
vatsan-madhavan
requested review from
ericstj,
miguep,
nguerrera,
ryalanms,
stevenbrix and
zsd4yr
nguerrera
approved these changes
Apr 18, 2019
mmitche
approved these changes
Apr 18, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part-2 of setting
RuntimeFrameworkVersionintentionally.For now, tests are opted-out of
RuntimeFrameworkVersionandTargetingPackVersion. Some tests continue to useSdk=Microsoft.NET.Sdk.WindowsDesktop- we need to move them to useSdk=Microsoft.NET.Sdkinstead, and opt-them also into usingRuntimeFrameworkVersion. We will do this after dotnet/arcade#2343 is merged and becomes available generally.We are not updating global.json tools.dotnet and sdk.version yet - we'll keep slightly older versions there as well until we make relevant changes to tests.