Add AssemblyMetadata[Language] attribute #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fadimounir, Please note that this attribute will not be added to the satellite assemblies (resource assemblies like WindowsBase.resources.dll etc.). |
fadimounir
reviewed
Apr 16, 2019
|
LGTM. Thanks @vatsan-madhavan for adding this metadata. We've identified the root cause of the bug and are investigating a fix, but it's useful anyways to have this attribute. |
Yes. We don't crossgen those anyways |
miguep
approved these changes
Apr 16, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #587
/cc @fadimounir