-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Setting default TargetPlatformVersion #3177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does this affect anything besides CsWinRT scenarios ? |
|
This change is more about future net5.0, net6.0 work. Detail is in there dotnet/sdk#11233 |
|
I’m asked after having looked there. The description there is a bit obscure but I found a link to dotnet/sdk#11556, which seemed suggestive. |
|
@vatsan-madhavan Daniel commented. @vatsan-madhavan @ryalanms, is there anything else you need to move forward? |
|
I’m all good - thanks for follow up and explaining! LGTM! |
|
My opinion is that we should put this type of Windows-specific logic (as well as the logic to reference CSWinRT targeting packs, etc.) in dotnet/sdk, and the targets in dotnet/wpf should be the ones that are specifically for WPF. I don't want to hold anything up if this way allows us to make progress faster, but that's where I'd like to end up. |
|
Lets' keep this going. We don't have much time left. We could do the shuffling in RC or post 5.0 |
|
@vatsan-madhavan @ryalanms is there anything else that needs to be done here? |
@wli3: Can you make sure to track this refactoring work in another issue? Thanks. |
|
I don't have merge access, but this should be ready to go. Thanks! |
Fixes dotnet/sdk#11233
cc @wli3