Skip to content

Conversation

@sfoslund
Copy link
Member

@sfoslund sfoslund requested a review from a team as a code owner June 24, 2020 21:47
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 24, 2020
@ghost ghost requested review from SamBent, fabiant3 and ryalanms June 24, 2020 21:47
@vatsan-madhavan
Copy link
Member

Does this affect anything besides CsWinRT scenarios ?

@wli3
Copy link

wli3 commented Jun 25, 2020

This change is more about future net5.0, net6.0 work. Detail is in there dotnet/sdk#11233

@vatsan-madhavan
Copy link
Member

I’m asked after having looked there. The description there is a bit obscure but I found a link to dotnet/sdk#11556, which seemed suggestive.

@wli3
Copy link

wli3 commented Jun 29, 2020

@vatsan-madhavan Daniel commented.

@vatsan-madhavan @ryalanms, is there anything else you need to move forward?

@vatsan-madhavan
Copy link
Member

vatsan-madhavan commented Jun 29, 2020

I’m all good - thanks for follow up and explaining! LGTM!

@dsplaisted
Copy link
Member

My opinion is that we should put this type of Windows-specific logic (as well as the logic to reference CSWinRT targeting packs, etc.) in dotnet/sdk, and the targets in dotnet/wpf should be the ones that are specifically for WPF.

I don't want to hold anything up if this way allows us to make progress faster, but that's where I'd like to end up.

@wli3 @sfoslund @vatsan-madhavan

@wli3
Copy link

wli3 commented Jun 30, 2020

Lets' keep this going. We don't have much time left. We could do the shuffling in RC or post 5.0

@sfoslund
Copy link
Member Author

sfoslund commented Jul 2, 2020

@vatsan-madhavan @ryalanms is there anything else that needs to be done here?

@ryalanms
Copy link
Member

ryalanms commented Jul 2, 2020

Lets' keep this going. We don't have much time left. We could do the shuffling in RC or post 5.0

@wli3: Can you make sure to track this refactoring work in another issue? Thanks.

@sfoslund
Copy link
Member Author

sfoslund commented Jul 2, 2020

I don't have merge access, but this should be ready to go. Thanks!

@ryalanms ryalanms merged commit e7cad62 into dotnet:master Jul 2, 2020
@sfoslund sfoslund deleted the DefaultTargetPlatform branch July 2, 2020 21:17
@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set default TargetPlatformVersion for Windows

5 participants