Skip to content

Conversation

@LakshanF
Copy link
Contributor

@LakshanF LakshanF commented Jun 19, 2024

Fixes #4461. Also restricted PresentationNative_cor3.dll to only WPF as pointed out here

@LakshanF LakshanF requested a review from ViktorHofer June 19, 2024 20:33
@LakshanF LakshanF self-assigned this Jun 19, 2024
@KalleOlaviNiemitalo
Copy link

Are all of those DLLs copied to the output directory, or only what the application references?

WindowsFormsIntegration seems like it should only be needed in those applications that set both UseWPF and UseWindowsForms.

System.IO.Packaging seems more relevant to the XPS file format support in WPF than to Windows Forms.

@LakshanF
Copy link
Contributor Author

Are all of those DLLs copied to the output directory, or only what the application references?

WindowsFormsIntegration seems like it should only be needed in those applications that set both UseWPF and UseWindowsForms.

System.IO.Packaging seems more relevant to the XPS file format support in WPF than to Windows Forms.

All the files will be copied to the output directory with SelfContained deployment in the following way.

With UseWindowsForms, any file that has WindowsForms or WindowsForms;WPF in the profile attribute will be copied and with UseWPF, any file that has WPF or WindowsForms;WPF in the profile attribute will be copied.

@ViktorHofer
Copy link
Member

Please hold off merging this until #4463 is merged. That one will again cause a merge conflict but we need that PR in asap.

@ViktorHofer ViktorHofer merged commit 16bd640 into dotnet:main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid duplication of FrameworkListFileClass information in sfxprojs

3 participants