Update PlatformManifest.txt with versions from 8.0 #4154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
approved these changes
Feb 12, 2024
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
This looks correct - it matches the file I see in "C:\Program Files\dotnet\packs\Microsoft.WindowsDesktop.App.Ref\8.0.0\data\PlatformManifest.txt" as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4152
The PlatformManifest.txt specifies versions that are lower than the ones specified in .NET 8 GA. This causes extra binaries to be created building an app that adds 8.0 nuget packages that overlap with Windowsdesktop. Fixing the PlatformManifest.txt to have the version specified in .NET 8 GA will avoid this behavior.