Argument completion pops up when function has no arguments

[Kotsuha]

Type: Bug

Issue Description

Steps to Reproduce

1. In Unity, create a Test script.

2. Copy-paste this example: https://docs.unity3d.com/2019.1/Documentation/ScriptReference/TestTools.Constraints.AllocatingGCMemoryConstraint.html

3. Place the cursor at the end of Is.AllocatingGCMemory. Press (.

Expected Behavior

VSCode should show a pop-up describing the method description and arguments.

Actual Behavior

Two pop-ups are shown. The first one is not as expected.

Logs

C# log

Post the output from Output-->C# here

C# LSP Trace Logs

Post the output from Output-->C# LSP Trace Logs here. Requires `dotnet.server.trace` to be set to `Trace`

Environment information

VSCode version: 1.82.1
C# Extension: 2.2.10
Using OmniSharp: false

Dotnet Information

Error running dotnet --info: Error: Command failed: C:\Program Files\dotnet\dotnet.exe --info 'C:\Program' is not recognized as an internal or external command, operable program or batch file.

'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

Visual Studio Code Extensions

Extension	Author	Version	Folder Name
csdevkit	ms-dotnettools	0.4.10	ms-dotnettools.csdevkit-0.4.10
csharp	ms-dotnettools	2.2.10	ms-dotnettools.csharp-2.2.10
vscode-dotnet-runtime	ms-dotnettools	1.7.3	ms-dotnettools.vscode-dotnet-runtime-1.7.3
vscode-settings-cycler	hoovercj	1.0.1	hoovercj.vscode-settings-cycler-1.0.1
vstuc	visualstudiotoolsforunity	0.9.0	visualstudiotoolsforunity.vstuc-0.9.0

Extension version: 2.2.10
VS Code version: Code 1.82.1 (6509174151d557a81c9d0b5f8a5a1e9274db5585, 2023-09-08T08:45:05.575Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-10980HK CPU @ 2.40GHz (16 x 3096)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	15.82GB (3.23GB free)
Process Argv	--crash-reporter-id 4f340c22-f013-4a44-bdbc-3bf3283d34dc
Screen Reader	no
VM	0%

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263cf:30335440
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30792226
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30803845
282f8724:30602487
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
962ge761:30835153
03d35959:30757346
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxptcf:30805731
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076
diffeditorv2:30821572
dsvsc015cf:30829746

[dibarbet]

Both popups are expected and appear to be correct. However generally you should be seeing both at once - the completion at the bottom and signature help above.
E.g.

If however, the bottom of the window is too close to the cursor, vscode will show the completion list up top, which covers signature help. You can see signature help in the background in your screenshot. You can dismiss completion by hitting escape.

The only thing we could do on the extension side is disable completion in argument lists, which we do not wish to do. We don't control the rendering here.
I'm closing this as by design

[Kotsuha]

@dibarbet Thank you for taking a look at this. I believe the Is.AllocatingGCMemory() takes zero parameters...? That's why I do not expect to see the first pop-up. In the GIF I posted, you can see the second pop-up does not show any overloads.

[dibarbet]

@Kotsuha ah I see now. Assigning to @genlu to see if we want to disable completion if the function has no parameters - though it might be too expensive as it requires semantic information to see if there are any overloads that take arguments.

[elavol]

I have the same problem, argument completion is so useless, no matter what type of function parameter, it always suggests by the alphabet of class, variables, namespace, etc...

[genlu]

@levanlongktmt Yea I hear you. The original motivation for triggering in argument list in C# (in VS) is that the intellicode would suggest the likely item via "starred item", plus we have a "target type filter" in VS that would filter down the list to items fit the inferred type in current context when selected. Neither of these are available in C# extension in vs code.

@dibarbet The PR I linked would avoid showing completion list if method has no parameter, but if it's still not enough, maybe we should consider disable the option in C# extension by default unless intellicode is available?