Remove prebuilt nupkgs from the tarball. #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keep a list of packages that are detected as prebuilts even though they aren't used in the tarball build. - Delete these packages after doing the normal filtering. - Enforce zero prebuilts in build-source-tarball, with a whitelist in case we need to regress on prebuilts.
dseefeld
approved these changes
Nov 6, 2019
crummel
added a commit
to crummel/dotnet_source-build
that referenced
this pull request
Nov 21, 2019
- Keep a list of packages that are detected as prebuilts even though they aren't used in the tarball build. - Delete these packages after doing the normal filtering. - Enforce zero prebuilts in build-source-tarball, with a whitelist in case we need to regress on prebuilts. * Add an option to skip zero prebuilt enforcement. * Don't fail on missing prebuilts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.