Skip to content

Remove redundant SourceBuildTrimNetFrameworkTargets property #3503

@NikolaMilosavljevic

Description

@NikolaMilosavljevic

We have originally added SourceBuildTrimNetFrameworkTargets property to most .NET repos to enable TFM trimming, in accordance with the original design: #3014

As a consequence, the following line was added to those repos (an example from installer):

https://github.com/dotnet/installer/blob/f8275a0edc0a90b593f2e3f73c4b9b3e908e3e22/eng/SourceBuild.props#LL8C50-L8C50

    <SourceBuildTrimNetFrameworkTargets>true</SourceBuildTrimNetFrameworkTargets>

After original implementation, TFM trimming work was further simplified, to use the opt-out logic, with: dotnet/arcade#13271

This property is not needed anymore, it causes unnecessary confusion and increased maintenance cost. Property should be removed at the earliest convenience.

To ensure proper tracking, for each repo, the list below should be updated with the PR link. Refer to original work (#3014) for the full list of repos and original changes. Note that some repos never used this property, i.e. emsdk and runtime.

Repositories

Metadata

Metadata

Assignees

Labels

area-upstream-fixNeeds a change in a contributing repo

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions