Add PackageVersion property to projects #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK uses the PackageVersion property as an input to NuGet package pruning and conflict resolution. Having correct inputs passed to conflict resolution is essential to support ProjectReferences in this repository as it handles deciding which asset to compile against (framework vs P2P). Until now, all projects use the default repository wide version information which is wrong. Therefore, update the task, template and msbuild generate project entrypoint to emit the PackageVersion property into the project files.
Automated change via the generate.sh script (and then filtering out unrelated changes).
mthalman
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1185
Contributes to dotnet/source-build#1690
The SDK uses the PackageVersion property as an input to NuGet package pruning and conflict resolution.
Having correct inputs passed to conflict resolution is essential to support ProjectReferences in this repository as it handles deciding which asset to compile against (framework vs P2P).
Until now, all projects use the default repository wide version information which is wrong.
Therefore, update the task, template and msbuild generate project entrypoint to emit the PackageVersion property into the project files.
Commit 2 is auto-generated via
generate.sh, only with unrelated files reverted. Commit 3 was applied manually.