IdentityModel patch to remove commit SHA #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
approved these changes
Aug 30, 2023
Member
|
@mthalman are you are going to backport this patch to the identity model repo? |
Member
Author
I wasn't planning on it. It's very much specific to source-build. |
Member
The whole reason the .sh file is in the repo is because of source-build, isn't it? |
Member
Author
That was the reason for adding it but that doesn't mean it's not relevant outside of source-build scenarios. It's a Bash version of the existing PowerShell script that does the same thing. Either can be used and should provide the same result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from #198 are causing the following build error when built in the context of a synchronized VMR build leg:
This is related to dotnet/source-build#3573. We can't execute
gitcommands in the build and don't yet have predefined git info we can use.