-
Notifications
You must be signed in to change notification settings - Fork 42
Upgrade Newtonsoft.Json repo from 13.0.1 to 13.0.3 #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Converting this to draft while I work through the build issues. |
|
I consolidated all the patch files into one. This was necessary because I needed to make an additional patch but that was conflicting due to overlap with other patches. So consolidating things made it easier to understand and cleaner. The change I made was to disable The reason for that is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please checkout the impact of this flowing into installer. I suspect this will pass because 13.0.1 will get picked up from n-1 artifacts. We should proactively add it to SBRP if that is the case.
This reverts commit ca7c730.
See #187 (comment)