-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Blazor] Remove unnecessary update to the Blazor webassembly js file #50949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blazor] Remove unnecessary update to the Blazor webassembly js file #50949
Conversation
ea052a7
to
faec67a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5146603
to
52ca4a7
Compare
93b1cc7
to
9c74276
Compare
9c74276
to
0dc4703
Compare
I see the same failure on an unrelated pr https://github.com/dotnet/sdk/pull/50948/checks?check_run_id=50914392897 so I'm comfortable it is not related to this change. I do wonder when it regressed though. cc @marcpopMSFT |
/backport to release/10.0.1xx-rc2 |
Started backporting to release/10.0.1xx-rc2: https://github.com/dotnet/sdk/actions/runs/17931765331 |
[Blazor] Remove unnecessary update to the Blazor webassembly js file
Remove redundant blazor.webassembly.js update that broke publish
Description
Hosted webassembly apps failed to publish due to a bug in how we were trying to update the
blazor.webassembly.js
asset definition. We realized that we did not have to do so, but that there was a bug precluding us from finding the asset during the publish process.The fix corrects the identity of the blazor.webassembly.js to account for the fingerprint for the file we introduced in 10.0, which wasn't being taken into account.
Fixes #119886
Customer Impact
Customers with a hosted Blazor WebAssembly + Web API (Server) solution failed to publish. There is no straightforward user workaround short of editing writing a significant amount of MSBuild to work around the issue.
Regression?
Regressed from .NET 8 (publishing the same project type succeeded in 8.x).
Risk
Justification: The change only removes an unnecessary build step and fixes a case that was exclusively related to Blazor webassembly. It does not alter the contents of the delivered script, pipeline ordering, or introduce new logic— it simply stops creating an anomalous asset entry. Existing publish & static web asset tests still apply. Low surface area and isolated to Blazor WASM publish scenario.
Verification
Packaging changes reviewed?