[dotnet-format] Include the .NET Framework buildhost executable in the SDK. #48969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
changed the title
arunchndr
approved these changes
May 15, 2025
|
@arunchndr @JoeRobich is this needed for July servicing and can you update the tactics template and send mail for approval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for dotnet-format to load .NET Framework projects.
Backport of #45290 to release/8.0.4xx
Description
Roslyn 4.9+ moved project loading out-of-process to a separate build host. Roslyn ships both .NET and .NET Framework build hosts in order to support framework projects. By not shipping the full framework build host dotnet-format now errors when trying to load full framework projects.
Risk
Low - This same change has shipped in the 9.0 SDKs and is not a change in behavior but a packaging change.
Regression
Yes. Prior to moving to Roslyn 4.9+ full framework projects were not supported by dotnet-format and there would be no error.
Testing