Skip to content

sln-add: Don't add solution folders outside the scope of solution directory #48611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

sln-add: Don't add solution folders outside the scope of solution directory #48611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d20f00
Also check for non rooted paths
edvilme Apr 22, 2025
5cc2b9f
Check for .. in every path segment
edvilme Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Cli/dotnet/commands/dotnet-sln/add/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ private async Task AddProjectsToSolutionAsync(string solutionFileFullPath, IEnum
foreach (var projectPath in projectPaths)
{
string relativePath = Path.GetRelativePath(Path.GetDirectoryName(solutionFileFullPath), projectPath);
// Add fallback solution folder if relative path does not contain `..`.
string relativeSolutionFolder = relativePath.Split(Path.DirectorySeparatorChar).Any(p => p == "..")
// Add auto-generated solution folder if relative path exists in the solution directory
string relativeSolutionFolder = (relativePath.Split(Path.DirectorySeparatorChar).Any(p => p == "..") || Path.IsPathRooted(relativePath))
? string.Empty : Path.GetDirectoryName(relativePath);

if (!_inRoot && solutionFolder is null && !string.IsNullOrEmpty(relativeSolutionFolder))
Expand Down
Loading