You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a small change to the Containers targets that defaults containerization to enabled for console applications. This support has been separately enabled for Web and Worker targets, but we never took the step of doing this for console apps
Regarding why we didn't do this earlier the reason was: back when we were initially doing these defaults, the primary way to publish a container was via a Publish Profile - which required the project to import a set of logic and Tasks called the 'Publish SDK'. Web and Worker SDK projects do this already, so they lit up container support easily. However, Console projects couldn't import the Publish SDK easily because of MSBuild ordering/layering constraints.
Customer Impact
Customers can call /t:PublishContainer for all executable .NET applications. dotnet new console && dotnet publish /t:PublishContainer Just Works. We've released this in 10p3 and feedback has been positive already!
Regression?
Nope, this was just a gap in our coverage.
Risk
Small - this just changes the default of a property that triggers the container support.
Tests
Tests were added to cover the new + publish workflow for console apps too.
That's frustrating. This has been setting for weeks in CI instability it seems.
Are you sure it's just CI instability? I looked at the failure, and it didn't look how I'd expect:
warning NETSDK1198: A publish profile with the name 'DefaultContainer' was not found in the project. Set the PublishProfile property to a valid file name.
Yeah, you're right - I took a look at it earlier today and it did seem to be a Real Thing ™️. Which is confusing because main didn't have any problems. I'm tinkering a bit in between other tasks, and if I can get it green I'll send something to Tactics.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
Backport of #47064 to release/9.0.3xx
Description
This PR is a small change to the Containers targets that defaults containerization to enabled for console applications. This support has been separately enabled for Web and Worker targets, but we never took the step of doing this for console apps
Regarding why we didn't do this earlier the reason was: back when we were initially doing these defaults, the primary way to publish a container was via a Publish Profile - which required the project to import a set of logic and Tasks called the 'Publish SDK'. Web and Worker SDK projects do this already, so they lit up container support easily. However, Console projects couldn't import the Publish SDK easily because of MSBuild ordering/layering constraints.
Customer Impact
Customers can call
/t:PublishContainerfor all executable .NET applications.dotnet new console && dotnet publish /t:PublishContainerJust Works. We've released this in 10p3 and feedback has been positive already!Regression?
Nope, this was just a gap in our coverage.
Risk
Small - this just changes the default of a property that triggers the container support.
Tests
Tests were added to cover the
new + publishworkflow for console apps too.