Skip to content

Conversation

@akoeplinger
Copy link
Member

Copilot AI review requested due to automatic review settings February 25, 2025 10:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Feb 25, 2025
@akoeplinger
Copy link
Member Author

akoeplinger commented Feb 25, 2025

@Youssef1313 this means users of the nightly sdk will also need this feed when using mstest, is that a concern?

@Youssef1313
Copy link
Member

I think either that, or maybe we can publish CodeCoverage to https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json, as that's where the repo was already getting MSTest 3.9 previews. cc @fhnaseer for the Code Coverage question.

@joeloff
Copy link
Member

joeloff commented Feb 25, 2025

My vote would be for dotnet-tools. For now, we can use test-tools to unblock the codeflow PRs because SDK has a significant number of open PRs we need to get through.

@nohwnd
Copy link
Member

nohwnd commented Feb 25, 2025

Code coverage should now push to dotnet-tools as well, re-running the original PR.

@nohwnd
Copy link
Member

nohwnd commented Feb 25, 2025

or you know what, merge this, so the other PR is unblocked, and then we can solve the usage of dotnet-tools in other PR, I don't want to step on your toes by reverting a commit when I am not 100% sure it will work :)

@akoeplinger
Copy link
Member Author

I think if the package is now on dotnet-tools that makes this PR obsolete since we can actually just retrigger the tests on the blocked PRs (since they would now be able to restore the package)

@Youssef1313
Copy link
Member

I don't yet see it in dotnet-tools:

image

@joeloff joeloff merged commit 9827576 into main Feb 25, 2025
42 checks passed
@joeloff joeloff deleted the akoeplinger-patch-1 branch February 25, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants