Skip to content

Clean-up in src/Layout/redist #46994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Clean-up in src/Layout/redist #46994

merged 1 commit into from
Feb 24, 2025

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 20, 2025 •
edited
Loading

  • Utilize up-front restore by depending on PackageDownload
  • Remove unused properties
  • Code formatting

Copilot AI review requested due to automatic review settings February 20, 2025 21:51
Copilot AI reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Feb 20, 2025
@ViktorHofer ViktorHofer marked this pull request as draft February 20, 2025 21:54
This was referenced Feb 21, 2025
Open
Open
@ViktorHofer ViktorHofer changed the title Minor clean-up in src/Layout/redist Clean-up in src/Layout/redist Feb 24, 2025
@ViktorHofer ViktorHofer marked this pull request as ready for review February 24, 2025 13:29
This was referenced Feb 24, 2025
Closed
Closed
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Feb 24, 2025

Failures are unrelated: #47024

@ViktorHofer ViktorHofer force-pushed the CleanupRedist branch 2 times, most recently from b03fba7 to e214968 Compare February 24, 2025 16:14
akoeplinger
akoeplinger approved these changes Feb 24, 2025
View reviewed changes
src/Layout/redist/targets/BundledSdks.targets
Comment on lines +38 to +39
%(BundledSdk.NuPkgPath)**\*.nupkg.metadata;
%(BundledSdk.NuPkgPath)**\*.signature.p7s"
Copy link
Member

@akoeplinger akoeplinger Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't these two in the root folder as well? why **?

Copy link
Member Author

@ViktorHofer ViktorHofer Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but not sure if they could exist in subfolders as well.

Copy link
Member

@akoeplinger akoeplinger Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't

@ViktorHofer ViktorHofer merged commit 2ae52ef into main Feb 24, 2025
34 of 40 checks passed
@ViktorHofer ViktorHofer deleted the CleanupRedist branch February 24, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViktorHofer @akoeplinger