-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add error for incorrect PublishSelfContained #46171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Due to lack of recent activity, this PR has been labeled as 'Stale'. It will be closed if no further activity occurs within 7 more days. Any new comment will remove the label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we want this as a warning instead of an error? This will definitely cause some breaking changes but I understand the idea. We may also want to consider this for PublishRuntimeIdentifier. Its likely too late to do this for 10 but we could do this for 11.
I think we would also want sign off from @baronfel or another PM if we wanted to do this from a product perspective. I think it's a good idea.
Thanks for the call-out @nagilson - definitely think there's value here, definitely agree that it's too late for 10 (our fault due to delays/time), definitely agree that it needs to be a warning, not an error, for at least a release. The error itself seems fine, it would be great if we had a help doc we could point to. I'm not sure if one exists that calls out the gaps with using |
For the following project (note it sets PublishSelfContained):
This command doesn't produce a self-contained publish output:
This adds an error message for this unsupported scenario.
Related: #32272 (discusses the PublishSelfContained behavior with /t:Publish)
Related: dotnet/runtime#95496
Related: #46070