Remove unused OverrideBootstrapVersions infrastructure #45550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
The linked issue in dotnet/source-build#3129 (comment) is still open. Does that issue still apply here? |
ViktorHofer
approved these changes
Dec 18, 2024
|
@MichaelSimons is this ready to merge? |
Not yet, I would like to validate a couple things. |
|
I verified (internal microsoft link) this cleanup in the context of 9.0. This gives me reasonable confidence this is not needed anymore. If we find a case where it is needed, it can easily be added back. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3129.
This is old infra that is no longer being used and should be cleaned up.