Skip to content

Initialization Stopwatch class #45413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Initialization Stopwatch class #45413

wants to merge 1 commit into from

Conversation

@Winniexu01
Copy link
Member

@Winniexu01 Winniexu01 commented Dec 11, 2024

Fixes dotnet/source-build#4803

This is a regression caused by #45393

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Dec 11, 2024
@KalleOlaviNiemitalo
Copy link
Contributor

KalleOlaviNiemitalo commented Dec 11, 2024

An alternative would be to make it Stopwatch? sw = null and then replace if (CommandLoggingContext.IsVerbose) with if (sw is not null) on line 75. That would avoid creating an unused instance of Stopwatch.

jjonescz
jjonescz requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jjonescz jjonescz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer #45411

@build-analysis build-analysis bot mentioned this pull request Dec 11, 2024
Open
ellahathaway
ellahathaway reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@ellahathaway ellahathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer #45411

Agreed. I think that we address this with the PR linked above.

@Winniexu01 Winniexu01 closed this Dec 12, 2024
@Winniexu01 Winniexu01 deleted the FixStopwatchClass branch April 11, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellahathaway ellahathaway ellahathaway left review comments

@jjonescz jjonescz jjonescz requested changes

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Main] SDK failed during build

4 participants

@Winniexu01 @KalleOlaviNiemitalo @jjonescz @ellahathaway