Skip to content

[main] Unlock build failed due to enabling nullable #45411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024
Merged

[main] Unlock build failed due to enabling nullable #45411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccdb746
Unlock build failed due to enabling nullable
Dec 11, 2024
c7fa87f
Merge branch 'main' into dev/Jason/unlock-build-failure-due-to-nullable
ViktorHofer Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Cli/Microsoft.DotNet.Cli.Utils/Command.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public CommandResult Execute(Action<Process>? processStarted)

_process.EnableRaisingEvents = true;

Stopwatch sw = null;
Stopwatch? sw = null;
if (CommandLoggingContext.IsVerbose)
{
sw = Stopwatch.StartNew();
Expand Down Expand Up @@ -78,7 +78,7 @@ public CommandResult Execute(Action<Process>? processStarted)
LocalizableStrings.ProcessExitedWithCode,
FormatProcessInfo(_process.StartInfo),
exitCode,
sw.ElapsedMilliseconds);
sw?.ElapsedMilliseconds);
Copy link
Member

@akoeplinger akoeplinger Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we know this is non-null in this case:

Suggested change
sw?.ElapsedMilliseconds);
sw!.ElapsedMilliseconds);

Copy link
Member

@marcpopMSFT marcpopMSFT Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we got strong guidance to avoid ! where possible by adding null checks. That being said, this seems like the compiler should know that this isn't null here and adding a null check seems incorrect as well. @JeremyKuhne in case he has advise or if this is the exception to that no ! guidance.

Copy link
Member

@JeremyKuhne JeremyKuhne Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case you can add a Debug.Assert(sw is not null); ahead of it. That will handle the case where someone changes the logic to where this is no longer true. @jaredpar who is the right person to ping about null analysis?

Copy link
Member

@jaredpar jaredpar Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this project multi-targetsbetween net472 and other TFMS but runs nullable analysis on all of them. That is the setup I advised against when I went by your desk @marcpopMSFT because it leads to situations like this. Debug.Assert has no impact on nullable analysis when targeting net472 because it doesn't have the new attributes.

Strongly recommend disabling nullable warnings on .NET Framework when you mulit-target with other TFMS.

Copy link
Contributor

@kasperk81 kasperk81 Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this wait? 180 pull requests are waiting for someone to press merge here. there is a syntax error in main branch for past 24 hours. the first impulse has to be to fix it or revert the change ASAP

Copy link
Member

@marcpopMSFT marcpopMSFT Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, I usually would want to get things right and green before merging as main is not our live branch but apparently enough people are targeting main that I'll go ahead and let it in as is.

Copy link
Member

@marcpopMSFT marcpopMSFT Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredpar I tried adding your suggestion of disabling nullable warnings for MT netfx builds but that doesn't work: #45420

I can confirm locally that DisableNullableWarnings is true in the netfix CLI.Utils build but I still get this warning: C:\repos\sdk\src\Cli\Microsoft.DotNet.Cli.Utils\Command.cs(82,21): error CS8602: Dereference of a possibly null reference. [C:\repos\sdk\src\Cli\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj]

if (exitCode == 0)
{
Reporter.Verbose.WriteLine(message.Green());
Expand Down
Loading