Skip to content

Conversation

v-wuzhai
Copy link
Contributor

@v-wuzhai v-wuzhai commented Dec 11, 2024

No description provided.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Dec 11, 2024
@v-wuzhai v-wuzhai mentioned this pull request Dec 11, 2024
6 tasks
@v-wuzhai
Copy link
Contributor Author

v-wuzhai commented Dec 12, 2024

@marcpopMSFT Looks like [InlineData("netcoreapp9.1")] is not a valid target framework version. Our test aims to ensure that the target framework version is higher than the current net10.0. However, netcoreapp9.1 is actually lower than net10.0, so it does not meet the test conditions. To ensure the validity of the test, we should use target framework versions higher than net10.0, such as netcoreapp10.1 or higher. What do you think?

@marcpopMSFT
Copy link
Member

@v-wuzhai the test already has netcoreapp10.1 which should be higher. Do we need anything else? If not, maybe we don't need this at all unless it's to test both a minor version higher in 10.1 and a major version higher in 11.0

@v-wuzhai v-wuzhai closed this Dec 13, 2024
@akoeplinger akoeplinger deleted the dev/Jason/add-netcoreapp9.1-to-framework-test branch March 18, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants