Fix warning level calculation for .NET 10 #45295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Youssef1313
commented
Dec 4, 2024
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
This was referenced Dec 4, 2024
Youssef1313
force-pushed
the
dev/ygerges/fix-warning-level
branch
from
847f894 to
8c8ceb7
Compare
6 tasks
|
@baronfel This is green now. Could we get it merged please? Thanks |
baronfel
approved these changes
Dec 4, 2024
|
Cc @marcpopMSFT we might have a few more time bombs lying in wait after the net10 transition |
akoeplinger
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/roslyn#76226