Skip to content

Enable Signing in Repos that Override Build Actions #44855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 16, 2024
Merged

Enable Signing in Repos that Override Build Actions #44855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0e78a8c
Enable Signing in Repos that Override Build Actions
ellahathaway Nov 13, 2024
4fed5a3
Only sign when DotNetBuildSourceOnly != true
ellahathaway Nov 13, 2024
9ef5b62
Pass msbuild sign prop to fsharp
ellahathaway Nov 14, 2024
6e21b96
Add fsharp patch
ellahathaway Nov 19, 2024
b521059
Remove sign prop from fsharp
ellahathaway Nov 20, 2024
e2b0e1d
Merge branch 'main' of https://github.com/dotnet/sdk into sign-all-repos
ellahathaway Nov 20, 2024
0dff3bc
Merge branch 'main' into sign-all-repos
ellahathaway Dec 2, 2024
90c2c0d
Remove fsharp patch
ellahathaway Dec 2, 2024
6ca5ecd
Merge branch 'main' into sign-all-repos
ellahathaway Dec 3, 2024
467c287
Merge branch 'main' of https://github.com/dotnet/sdk into sign-all-repos
ellahathaway Dec 5, 2024
a8b7fb5
Add fsharp patch to allow empty ItemsToSign list
ellahathaway Dec 5, 2024
5792a5a
Remove fsharp patch
ellahathaway Dec 6, 2024
9753b8d
Pass -noVisualStudio on windows when building wiht core msbuild
ellahathaway Dec 6, 2024
56f3d9e
Merge branch 'main' into sign-all-repos
ellahathaway Dec 16, 2024
b8dc8d6
Assume we won't sign in SB only mode
ellahathaway Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/SourceBuild/content/repo-projects/aspnetcore.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<BuildScript>$(ProjectDirectory)eng\build$(ShellExtension)</BuildScript>

<BuildActions Condition="'$(DotNetBuildSourceOnly)' != 'true'">$(FlagParameterPrefix)restore $(FlagParameterPrefix)all $(FlagParameterPrefix)pack $(FlagParameterPrefix)publish</BuildActions>
<BuildActions Condition="'$(Sign)' == 'true'">$(BuildActions) $(FlagParameterPrefix)sign</BuildActions>
<!-- On windows, native tooling (JDK) is pre-installed on the machine. -->
<BuildActions Condition="'$(BuildOS)' == 'windows'">$(BuildActions) -NativeToolsOnMachine</BuildActions>
<!-- On non-windows, we don't have the JDK available and don't need to build those projects anyway because they are not consumed downstream. -->
Expand Down
4 changes: 4 additions & 0 deletions src/SourceBuild/content/repo-projects/fsharp.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

<!-- Restore and Build actions are already passed in by the root script. -->
<BuildActions>$(FlagParameterPrefix)pack $(FlagParameterPrefix)publish</BuildActions>
<BuildActions Condition="'$(Sign)' == 'true'">$(BuildActions) $(FlagParameterPrefix)sign</BuildActions>

<!-- noVisualStudio build action must be passed if building with Core MSBuild on Windows. -->
<BuildActions Condition="'$(BuildOS)' == 'windows' and '$(ForceDotNetMSBuildEngine)' != 'false'">$(BuildActions) $(FlagParameterPrefix)noVisualStudio</BuildActions>

<BuildArgs>$(BuildArgs) /p:TreatWarningsAsErrors=false</BuildArgs>
<BuildArgs>$(BuildArgs) /p:GenerateResourceUsePreserializedResources=true</BuildArgs>
Expand Down
1 change: 1 addition & 0 deletions src/SourceBuild/content/repo-projects/roslyn.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<BuildActions Condition="'$(BuildOS)' == 'windows'">$(FlagParameterPrefix)restore</BuildActions>
<BuildActions Condition="'$(BuildOS)' == 'windows'">$(BuildActions) $(FlagParameterPrefix)pack</BuildActions>
<BuildActions Condition="'$(BuildOS)' == 'windows'">$(BuildActions) $(FlagParameterPrefix)publish</BuildActions>
<BuildActions Condition="'$(BuildOS)' == 'windows' and '$(Sign)' == 'true'">$(BuildActions) $(FlagParameterPrefix)sign</BuildActions>

<!-- Use the repo root build script -->
<BuildScript>$(ProjectDirectory)build$(ShellExtension)</BuildScript>
Expand Down
Loading