Skip to content

Conversation

ViktorHofer
Copy link
Member

Needed for #43015

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 29, 2024
@ViktorHofer ViktorHofer enabled auto-merge (squash) October 29, 2024 15:47
@am11
Copy link
Member

am11 commented Oct 29, 2024

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Oct 29, 2024

You mean because the VMR's SDK is behind by one preview release? No, we want nightly 10.0 SDK releases to bring the latest available runtime and targeting packs from the 9.0 release in. I don't think that the VMR would break because of this.

@am11
Copy link
Member

am11 commented Oct 29, 2024

Ah, but do you at what point we will define <_NET100..Version? Maybe this is the right time for that.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Oct 29, 2024

I'm doing the minimal change here to unblock #43015. I'm not really familiar with when or how the SDK team updates these versions so I would defer to them on that.

@marcpopMSFT
Copy link
Member

We already did the known framework work here: #42969 This list is the downlevel implicit version and we update it to a stable version once we have a released 9.0.0 version. Going to rc2 in the interim is fine.

@ViktorHofer ViktorHofer merged commit ded76b9 into main Oct 29, 2024
37 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-3 branch October 29, 2024 20:30
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Oct 29, 2024

@marcpopMSFT The stale P7 version is blocking the net10.0 PR which is why I had to submit this PR. See #43015 (comment)

@am11
Copy link
Member

am11 commented Oct 30, 2024

@ViktorHofer sb failed due to missing packages https://dev.azure.com/dnceng-public/public/_build/results?buildId=856092&view=results

  Restored /vmr/eng/finish-source-only.proj (in 97 ms).
  Restored /vmr/eng/extract-sdk-archive.proj (in 97 ms).
/vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 9.0.0-rc.2.24473.5) [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj : error NU1102:   - Found 7 version(s) in /vmr/prereqs/packages/reference/ [ Nearest version: 8.0.0 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj : error NU1102:   - Found 1 version(s) in /vmr/prereqs/packages/prebuilt/ [ Nearest version: 9.0.0-rc.1.24431.7 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj : error NU1102:   - Found 1 version(s) in /vmr/prereqs/packages/previously-source-built/ [ Nearest version: 9.0.0-preview.7.24405.7 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 9.0.0-rc.2.24473.5) [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj : error NU1102:   - Found 7 version(s) in /vmr/prereqs/packages/reference/ [ Nearest version: 8.0.0 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj : error NU1102:   - Found 1 version(s) in /vmr/prereqs/packages/prebuilt/ [ Nearest version: 9.0.0-rc.1.24431.7 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj : error NU1102:   - Found 1 version(s) in /vmr/prereqs/packages/previously-source-built/ [ Nearest version: 9.0.0-preview.7.24405.7 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Ref with version (= 9.0.0-rc.2.24474.3) [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj : error NU1102:   - Found 2 version(s) in /vmr/prereqs/packages/reference/ [ Nearest version: 8.0.0 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj : error NU1102:   - Found 1 version(s) in /vmr/prereqs/packages/previously-source-built/ [ Nearest version: 9.0.0-preview.7.24406.2 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj : error NU1102:   - Found 0 version(s) in /vmr/prereqs/packages/prebuilt/ [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Ref with version (= 9.0.0-rc.2.24474.3) [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj : error NU1102:   - Found 2 version(s) in /vmr/prereqs/packages/reference/ [ Nearest version: 8.0.0 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj : error NU1102:   - Found 1 version(s) in /vmr/prereqs/packages/previously-source-built/ [ Nearest version: 9.0.0-preview.7.24406.2 ] [/vmr/build.proj]
/vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj : error NU1102:   - Found 0 version(s) in /vmr/prereqs/packages/prebuilt/ [/vmr/build.proj]
  Failed to restore /vmr/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj (in 271 ms).
  Failed to restore /vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.csproj (in 271 ms).

do we need a new source build baseline or just add these packages to one of the package feeds it's searching in?

@ViktorHofer
Copy link
Member Author

@am11 commented in the other PR and asked the soruce-build team. I think we just need to update the Private.SourceBuilt packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants