Update tfm of dotnet/format test project to current #44498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ViktorHofer
approved these changes
Oct 29, 2024
|
@arunchndr Did you want someone from format to review these types of changes? v-wuzhai had been tasked with cleaning out old targeting tests from the SDK repo and with format now here, looks like he updated some format tests as well. |
|
Added a few reviewers for the format area per arunchndr offline. |
JoeRobich
approved these changes
Nov 5, 2024
Comment on lines
+11
to
+14
|
|
||
| public MSBuildWorkspaceFinderTests(ITestOutputHelper log) : base(log) | ||
| { | ||
| } |
There was a problem hiding this comment.
nit: empty line after ctor
Suggested change
| public MSBuildWorkspaceFinderTests(ITestOutputHelper log) : base(log) | |
| { | |
| } | |
| public MSBuildWorkspaceFinderTests(ITestOutputHelper log) : base(log) | |
| { | |
| } | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.