Skip to content

Conversation

v-wuzhai
Copy link
Contributor

No description provided.

@v-wuzhai v-wuzhai requested a review from a team as a code owner October 22, 2024 03:13
@ghost ghost added Area-Common templates Covers templates in the repo (classlib, console, common item templates) untriaged Request triage from a team member labels Oct 22, 2024
@v-wuzhai
Copy link
Contributor Author

Looks like we need to merge the #43015 code flow first to address the error message.

error NETSDK1045: The current .NET SDK does not support targeting .NET 10.0. Either target .NET 9.0 or lower, or use a version of the .NET SDK that supports .NET 10.0. Download the .NET SDK from https://aka.ms/dotnet/download

@marcpopMSFT
Copy link
Member

@v-wuzhai the other PR is now in so we can fix the merge conflicts and start getting this one unblocked.

"datatype": "bool",
"parameters": {
"pattern": "^(net5.0|net6.0|net7.0|net8.0|net9.0)$*",
"pattern": "^(net5.0|net6.0|net7.0|net8.0|net9.0|net10.0)$*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pattern": "^(net5.0|net6.0|net7.0|net8.0|net9.0|net10.0)$*",
"pattern": "^net([5-9]|[1-9]\\d{1,})\\.0$*",

as done in

"\"Crossgen2PackVersion\":\"([5-9]|[1-9]\\d{1,})\\..+\"");

@kasperk81
Copy link
Contributor

ci checks passed @marcpopMSFT
dotnet/roslyn#75795 is making roslyn net5+ to roslyn version mapping dynamic, which warns during msbuild:LangVersion binding in template engine, until that target is updated. with dynamic approach, it'd be the last time that roslyn file needs an update

@marcpopMSFT
Copy link
Member

Should we remove the 9.0 templates (like we removed 8.0 from the 9.0 branch)?
Should we unwind 426b043?

We can do those changes in a separate PR. Still not sure why the net9.0 version is missing from the test run as it'll be needed eventually. Is that because we're using a VS image that doesn't have 9 yet maybe?

Copy link
Member

@marcpopMSFT marcpopMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming we'll do the other changes I outlined in a separate PR.

@v-wuzhai
Copy link
Contributor Author

v-wuzhai commented Nov 8, 2024

@marcpopMSFT I will submit a separate PR to address the issues you mentioned.

@v-wuzhai v-wuzhai merged commit c87de36 into main Nov 8, 2024
37 checks passed
@v-wuzhai v-wuzhai deleted the dev/Jason/createProjectTemplatesTargetTo10 branch November 8, 2024 02:22
@v-wuzhai
Copy link
Contributor Author

v-wuzhai commented Nov 8, 2024

@marcpopMSFT I have created an issue to track the missing net9.0 templates: #44736. We will update our test environment once the templates are available.

@v-wuzhai v-wuzhai mentioned this pull request Dec 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Common templates Covers templates in the repo (classlib, console, common item templates) untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants