Skip to content

Fine tune first join point and VMR support for it #44153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Oct 17, 2024
Merged

Fine tune first join point and VMR support for it #44153

merged 25 commits into from
Oct 17, 2024

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Oct 14, 2024 •
edited
Loading

  • Remove not needed global property from sdk's eng/DotNetBuild.props
  • Make sure that the job name includes the build pass number
  • Make the join point vertical not replace the original vertical but be an addtional vertical
  • Make sure that the DotNetBuildPass property gets passed in globally in the VMR orchestrator, not just for dotnet/sdk (for future join points).
  • Correctly condition the components to be built on BuildPass=2
  • Only build repos in the VMR that are marked to be built for that join point
  • Make it possible to build the VSTemplateLocator component without needing to build the whole sdk again (1min vs ~10min build time)

@ViktorHofer ViktorHofer requested review from a team as code owners October 14, 2024 13:17
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 14, 2024
ViktorHofer
ViktorHofer commented Oct 14, 2024
View reviewed changes
@ViktorHofer ViktorHofer mentioned this pull request Oct 14, 2024
Merged
This was referenced Oct 14, 2024
Open
Closed
Closed
mmitche
mmitche reviewed Oct 14, 2024
View reviewed changes
mmitche
mmitche reviewed Oct 14, 2024
View reviewed changes
am11
am11 reviewed Oct 15, 2024
View reviewed changes
ViktorHofer added a commit to dotnet/arcade that referenced this pull request Oct 15, 2024
@ViktorHofer
Don't allow empty repo builds when DotNetBuildPass > 1
5e6e5b2 
We explicitly don't want empty repo builds and are changing the VMR orchestrator infra in dotnet/sdk#44153 to not trigger such repo builds.
@ViktorHofer ViktorHofer mentioned this pull request Oct 15, 2024
Merged
1 task
This was referenced Oct 16, 2024
Open
Closed
@ViktorHofer
Fine tune first join point
a0ccac1 
- Remove not needed global property from sdk's eng/DotNetBuild.props
- Make sure that the job name includes the build pass number
- Make the join point vertical not replace the original vertical but be an addtional vertical
- Make sure that the DotNetBuildPass property gets passed in globally in the VMR orchestrator, not just for dotnet/sdk (for future join points).
- Correctly condition the components to be built on BuildPass=2
@ViktorHofer
Test join point
c569ce6
@ViktorHofer
Build only repos in the VMR that should be built for join point verti…
91bc040 
…cals (buildpass>1)
@ViktorHofer
Update vmr-build.yml
076cc04
@ViktorHofer
Build right assets in buildpass=2
f856cc3
@ViktorHofer
MSI change that was missed
21ef7ff
@ViktorHofer
Correctly build VSTemplateLocator package
ef92119
@ViktorHofer
VSTemplateLocator fix
7f4b0aa
@ViktorHofer
one more vstemplatelocator fix
923aa6e
@ViktorHofer
fix source-build leg
5144584
@ViktorHofer
Change error to condition for dependent projects
3f1a53c
@build-analysis build-analysis bot mentioned this pull request Oct 16, 2024
Open
ViktorHofer
ViktorHofer commented Oct 17, 2024
View reviewed changes
@ViktorHofer ViktorHofer mentioned this pull request Oct 17, 2024
Merged
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Oct 17, 2024 •
edited
Loading

So this is ready. As mentioned in the top post, with this PR we now correctly implement a join point build leg that adds artifacts.

Things for follow-up PRs:

  • Make it possible to build the VS.Redist.Common.Net.Core.SDK.MSBuildExtensions package standalone and correctly sequence it into the existing joint point. (It's not getting produced yet)
  • Explore ideas how to not upload all the artifacts from the dependent jobs in the join point vertical.

mmitche
mmitche reviewed Oct 17, 2024
View reviewed changes
@mmitche
Copy link
Member

mmitche commented Oct 17, 2024

Merging around checks as just a temp YAML change was reverted.

@mmitche mmitche merged commit 7deb362 into main Oct 17, 2024
3 of 36 checks passed
@mmitche mmitche deleted the BuildPass2Components branch October 17, 2024 15:26
This was referenced Oct 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelSimons MichaelSimons MichaelSimons left review comments

@mmitche mmitche mmitche approved these changes

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ViktorHofer @mmitche @am11 @MichaelSimons