Skip to content

Avoid UsingTask when the target does not exist #42238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

Avoid UsingTask when the target does not exist #42238

merged 1 commit into from
Jul 18, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Jul 18, 2024 •
edited
Loading

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Jul 18, 2024
@jjonescz jjonescz mentioned this pull request Jul 18, 2024
Merged
@build-analysis build-analysis bot mentioned this pull request Jul 18, 2024
Open
@jjonescz jjonescz marked this pull request as ready for review July 18, 2024 16:55
rainersigwald
rainersigwald approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is the silent fallback to previous (bad) behavior if restore is done outside of VS and then VS doesn't retrigger restore. This definitely seems like an improvement.

@jjonescz
Copy link
Member Author

My only concern here is the silent fallback to previous (bad) behavior if restore is done outside of VS and then VS doesn't retrigger restore.

If we follow up with #42216 there will be no silent fallback (we will instead report an error if we cannot find the package during compilation).

@jjonescz jjonescz merged commit db3abee into dotnet:main Jul 18, 2024
@jjonescz jjonescz deleted the tearing-conditional branch July 18, 2024 19:38
@jjonescz jjonescz mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@dsplaisted dsplaisted Awaiting requested review from dsplaisted

@jaredpar jaredpar Awaiting requested review from jaredpar

@baronfel baronfel Awaiting requested review from baronfel

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jjonescz @rainersigwald