Fix TestPackage paths #42136
Merged
Fix TestPackage paths #42136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tAssets/TestPackages/.
ghost
added
marcpopMSFT
approved these changes
Jul 12, 2024
3 tasks
nagilson
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #41924, I changed the assumption to be that all TestPackages come from
test/TestAssets/TestPackages/. Earlier today, there was this PR that added a TestPackage that is atsrc/Microsoft.Net.Sdk.Compilers.Toolset. So, the simplification I made in my PR wouldn't work and caused the build to fail. This fixes it by reverting to the previous logic where there is no assumption of the path to the TestPackages after the repo root.