Skip to content

rename SDK_CONTAINER_* to DOTNET_CONTAINER #41769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 26, 2024
Merged

rename SDK_CONTAINER_* to DOTNET_CONTAINER #41769

merged 7 commits into from
Jun 26, 2024

Conversation

@kasperk81
Copy link
Contributor

fix #41609

@kasperk81 kasperk81 requested a review from a team as a code owner June 24, 2024 16:28
@ghost ghost added Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member labels Jun 24, 2024
baronfel
baronfel requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this! We can't take this change as a direct name replacement right now, at minimum we have to keep backwards compatibility with the existing names so that we don't break azd without helping them migrate: https://github.com/ellismg/azure-dev/blob/947e1b8fab76c74b59d15c3bc46607e9038a0072/cli/azd/pkg/tools/dotnet/dotnet.go#L171.

@kasperk81
Copy link
Contributor Author

kasperk81 commented Jun 24, 2024 •
edited
Loading

@baronfel I've added fallback to legacy except for DOTNET_CONTAINER_INSECURE_REGISTRIES which was added last week

@build-analysis build-analysis bot mentioned this pull request Jun 24, 2024
Open
3 tasks
@baronfel baronfel requested a review from a team June 25, 2024 17:33
@baronfel
Copy link
Member

If we can get the build to go green we'll merge this - and also backport to 8.0.4xx so that we don't have to release the insecure registry support with the old-style environment variable at all. Thanks for this @kasperk81!

@build-analysis build-analysis bot mentioned this pull request Jun 26, 2024
Closed
@baronfel baronfel merged commit 7969bf8 into dotnet:main Jun 26, 2024
@baronfel
Copy link
Member

baronfel commented Jun 26, 2024 •
edited
Loading

/backport to release/8.0.4xx

1 similar comment
@baronfel
Copy link
Member

/backport to release/8.0.4xx

@github-actions
Copy link
Contributor

Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/9684194875

@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baronfel baronfel baronfel approved these changes

@MichalPavlik MichalPavlik MichalPavlik approved these changes

Assignees

No one assigned

Labels

Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

environment variables with DOTNET_CONTAINER_ or DOTNET_SDK_CONTAINER_ prefix

3 participants

@kasperk81 @baronfel @MichalPavlik