Skip to content

Conversation

@baronfel
Copy link
Member

Fixes #41530

The commands that implicitly drive MSBuild by forwarding properties should all be available across the set of MSBuild-invoking commands. An important exception to this rule is the dotnet msbuild command itself, which is a kind of low-level command that doesn't apply as many convenience tools.

@ghost ghost added Area-CLI untriaged Request triage from a team member labels Jun 11, 2024
@baronfel baronfel requested a review from a team June 11, 2024 21:22
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I like the way you designed the tests to verify each of the options are on each of the build related commands, very clean :)

@baronfel
Copy link
Member Author

I like the way you designed the tests to verify each of the options are on each of the build related commands, very clean :)

Yeah, I fully expect to want to establish more baselines for options (right off the top of my head I can see use for -c, -r, -f, etc) and I wanted to make sure that was super easy to do.

…implicit restore

without this, the option is applied multiple times to implicit restores triggered by build, test, etc
@baronfel baronfel merged commit 5d4dadb into dotnet:release/8.0.4xx Jun 12, 2024
@baronfel baronfel deleted the add-missing-flag-to-restore branch June 12, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CLI untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants